Repository navigation
fix: make one-shot install deterministic and update GPUI - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
igniter.newflow deterministic in non-interactive environments by accepting the package confirmation55007f518bc1d49e6b3291c5eaa1aabf649b36fdRoot cause
Without
--yes, Igniter reaches the Hex package confirmation after Phoenix has already been generated. In a non-interactive process stdin is EOF, so the command exits before installing Rekindle and leaves the Phoenix tree behind. Igniter correctly forwards--pluginand--targets; the Rekindle installer itself works.Verification
mix format --check-formattedmix compile --warnings-as-errorsRUSTUP_HOME=/home/munenick/.rustup CARGO_HOME=/home/munenick/.cargo mix test --exclude plugin_matrix(118 passed)mix reach.check --arch --dead-codemix reach.check --smells --strictmix docs --warnings-as-errorsRUSTUP_HOME=/home/munenick/.rustup CARGO_HOME=/home/munenick/.cargo REKINDLE_PLUGIN=gpui mix test test/rekindle/plugin_test.exs --include plugin_matrix(6 passed)cargo test --locked(1 passed)cargo check --locked