Skip to content

Put engine/ before other paths when including #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WPettersson wants to merge 2 commits into
base: service-7.0
Choose a base branch
from
Open

Put engine/ before other paths when including #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
642df10
Put engine/ before other paths when including
WPettersson Feb 14, 2022
79a36c2
Add comments as to why we need BEFORE
WPettersson Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/regina/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ FOREACH (SOURCE_FILE ${SOURCES})
SET (RELSOURCES ${RELSOURCES} ../${SOURCE_FILE})
ENDFOREACH (SOURCE_FILE)

INCLUDE_DIRECTORIES("${CMAKE_SOURCE_DIR}/engine" "${CMAKE_BINARY_DIR}/engine" ${Python_INCLUDE_DIRS})
# Note that we need BEFORE here to ensure that our internal libnormaliz
# headers are used before any external libnormaliz headers that may be
# found from a users install.
INCLUDE_DIRECTORIES(BEFORE "${CMAKE_SOURCE_DIR}/engine" "${CMAKE_BINARY_DIR}/engine" ${Python_INCLUDE_DIRS})
ADD_LIBRARY("engine" MODULE ${RELSOURCES} )

# Python modules on linux should not have the "lib" prefix
Expand Down