Split the merkle example into separate crates #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
changed the title
iamrecursion
force-pushed
the
merkle_split
branch
from
6ae5aca to
3f48f2f
Compare
Eduardogbg
force-pushed
the
merkle_split
branch
5 times, most recently
from
937c9a9 to
f83762b
Compare
Eduardogbg
force-pushed
the
merkle_split
branch
from
f83762b to
73a8c53
Compare
Eduardogbg
force-pushed
the
merkle_split
branch
5 times, most recently
from
51b3de0 to
b409922
Compare
Add the ability for the lampe CLI to detect and handle Noir workspaces with multiple crates. When run on a directory containing multiple Nargo.toml subdirectories (but no root Nargo.toml), the CLI will extract each crate that has a lampe/ directory. Changes: - src/bin/main.rs: Add workspace detection (is_workspace_root, has_workspace_manifest, list_workspace_crates, select_workspace_crates) and run_workspace_root to iterate over workspace crates - src/project.rs: Add lampe_targets field and with_lampe_targets builder to track which packages should be treated as having lampe output, allowing workspace crates to reference each other during extraction
Eduardogbg
force-pushed
the
merkle_split
branch
2 times, most recently
from
ce099a1 to
0f44048
Compare
Eduardogbg
force-pushed
the
merkle_split
branch
from
0f44048 to
7198aeb
Compare
Restructure the Merkle testing example from a single crate into a workspace with three separate crates: - hasher: Core hashing interface - skyscraper: Skyscraper permutation implementation - merkle: Main merkle tree implementation using the above This demonstrates and tests the multi-crate workspace support added in the previous commit. Co-Authored-By: Matej Penciak <matej.penciak@gmail.com>
Eduardogbg
force-pushed
the
merkle_split
branch
from
7198aeb to
db9e907
Compare
kustosz
reviewed
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181.