feat: display selected repo and installed TizenBrew version on home screen - #36
Open
KrX3D wants to merge 13 commits into
Open
feat: display selected repo and installed TizenBrew version on home screen#36KrX3D wants to merge 13 commits into
KrX3D wants to merge 13 commits into
Conversation
Only en and tr had the string added in the upstream select-file-to-install commit.
Switch InstallFromGitHub's repo field to type="email", matching the input type TizenBrew's ModuleManager uses, which triggers Tizen's locale (QWERTZ) keyboard instead of the generic QWERTY one shown for type="text". Also stop left/right arrow keydowns from propagating on this field and the TV-IP field on the Desktop page, so norigin-spatial-navigation's global listener doesn't steal them for focus movement before the native text cursor can use them.
Sync upstream: file install + InstallFile precondition + createStream fix
fix: QWERTZ keyboard and left/right arrow keys on text inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
reisxd/TizenBrewby default)and the currently installed TizenBrew version on the update button
localStorageso it survives app restartsWhy
Users had no way to tell at a glance whether TizenBrew was installed or
which version they had without starting the install process.
Testing