feat: Add Default Speed for Music Videos - #399
Open
JensorX wants to merge 5 commits into
Open
Conversation
ice-fly
approved these changes
Mar 23, 2026
ice-fly
left a comment
There was a problem hiding this comment.
Your logic appears to work and I agree with the feature.
Just a thought:
I feel like the majority of videos will not be music, so perhaps this would be a good opportunity to lazily determine if the video is a music video as the page renders (the first 25ms of music at 2x probably doesn't matter and this may aid performance on the other case where users want fast playback).
Author
|
Good Idea! |
ice-fly
approved these changes
Apr 4, 2026
Move the 'Default Speed for Music Videos' option to videoPlayer settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new "Default Speed for Music Videos" setting to the settings page.
If this setting is activated, the speed of music videos will be automatically set to 1x (regardless of the default playback speed) with a music video detection.
Example:
User watches a normal video -> 1.5x speed
After that, the User watches a Music Video -> 1x speed
User watches a normal video -> 1.5x speed