Skip to content

Align data model docs with actual ReconciliationPolicy API#54

Merged
akollegger merged 2 commits into031-pattern-reconciliationfrom
copilot/sub-pr-52-again
Jan 27, 2026
Merged

Align data model docs with actual ReconciliationPolicy API#54
akollegger merged 2 commits into031-pattern-reconciliationfrom
copilot/sub-pr-52-again

Conversation

Copy link
Contributor

Copilot AI commented Jan 26, 2026

The data model documentation described a MergeStrategy type combining labels, properties, and elements into a single record, but the implementation uses separate ElementMergeStrategy and SubjectMergeStrategy types with a parameterized ReconciliationPolicy s.

Changes

  • Type definitions: Updated ReconciliationPolicy from simple ADT to ReconciliationPolicy s with Merge constructor taking ElementMergeStrategy and value-specific strategy s
  • Split strategy types: Replaced unified MergeStrategy with:
    • ElementMergeStrategy for element list merging (ReplaceElements | AppendElements | UnionElements)
    • SubjectMergeStrategy for Subject content with labelMerge and propertyMerge fields
  • Default strategy: Updated defaultMergeStrategy references to defaultSubjectMergeStrategy
  • Code examples: Updated quickstart.md examples to reflect actual API usage

Example

Before (documented but not implemented):

let strategy = MergeStrategy UnionLabels ShallowMerge UnionElements
reconcile (Merge strategy) pattern

After (actual implementation):

let subjectStrategy = SubjectMergeStrategy UnionLabels ShallowMerge
reconcile (Merge UnionElements subjectStrategy) pattern
-- Or use default: Merge UnionElements defaultSubjectMergeStrategy

Updated files: data-model.md, quickstart.md, research.md, spec.md, tasks.md


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP: Address feedback on 031 pattern reconciliation PR Align data model docs with actual ReconciliationPolicy API Jan 26, 2026
Copilot AI requested a review from akollegger January 26, 2026 09:24
Copy link
Contributor

@akollegger akollegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong direction for a fix.

@akollegger akollegger marked this pull request as ready for review January 27, 2026 09:36
@akollegger akollegger merged commit 75872bc into 031-pattern-reconciliation Jan 27, 2026
@akollegger akollegger deleted the copilot/sub-pr-52-again branch January 27, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants