Align data model docs with actual ReconciliationPolicy API#54
Merged
akollegger merged 2 commits into031-pattern-reconciliationfrom Jan 27, 2026
Merged
Align data model docs with actual ReconciliationPolicy API#54akollegger merged 2 commits into031-pattern-reconciliationfrom
akollegger merged 2 commits into031-pattern-reconciliationfrom
Conversation
Co-authored-by: akollegger <53756+akollegger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP: Address feedback on 031 pattern reconciliation PR
Align data model docs with actual ReconciliationPolicy API
Jan 26, 2026
akollegger
approved these changes
Jan 27, 2026
Contributor
akollegger
left a comment
There was a problem hiding this comment.
This is the wrong direction for a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data model documentation described a
MergeStrategytype combining labels, properties, and elements into a single record, but the implementation uses separateElementMergeStrategyandSubjectMergeStrategytypes with a parameterizedReconciliationPolicy s.Changes
ReconciliationPolicyfrom simple ADT toReconciliationPolicy swithMergeconstructor takingElementMergeStrategyand value-specific strategysMergeStrategywith:ElementMergeStrategyfor element list merging (ReplaceElements | AppendElements | UnionElements)SubjectMergeStrategyfor Subject content withlabelMergeandpropertyMergefieldsdefaultMergeStrategyreferences todefaultSubjectMergeStrategyExample
Before (documented but not implemented):
After (actual implementation):
Updated files: data-model.md, quickstart.md, research.md, spec.md, tasks.md
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.