Skip to content

pattern-reconciliation: implmented tests that were pending #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akollegger merged 1 commit into from
Feb 12, 2026
Merged

pattern-reconciliation: implmented tests that were pending #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libs/pattern/tests/Spec/Pattern/ReconcileProperties.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,13 @@ spec = do
let ids = collectAllIdentities reconciled
in length ids === length (Set.fromList ids)

-- Full Merge support with element deduplication is implemented in Phase 4
it "each identity appears at most once after reconciliation (Merge)" $
pendingWith "Full Merge with element deduplication is Phase 4 (User Story 2)"
property $ \(pattern :: Pattern Subject) ->
case reconcile (Merge UnionElements defaultSubjectMergeStrategy) pattern of
Left _ -> property True -- Error case doesn't apply
Right reconciled ->
let ids = collectAllIdentities reconciled
in length ids === length (Set.fromList ids)

describe "Determinism Properties" $ do
it "reconciling the same pattern twice gives identical results (LastWriteWins)" $
Expand Down
2 changes: 1 addition & 1 deletion specs/031-pattern-reconciliation/spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

**Feature Branch**: `031-pattern-reconciliation`
**Created**: 2026-01-23
**Status**: Draft
**Status**: Implemented (2026-02-12)
**Input**: User description: "Pattern Subject reconciliation as described in proposals/pattern-reconciliation.md"

## Clarifications
Expand Down
Loading