Migrate from Bacon to Minitest and modernize project #1
+1,425
−1,405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the unmaintained Bacon test framework with Minitest::Test. Rename spec/ to test/ following Ruby conventions (*_test.rb suffix). Use prepend-based test mocking instead of class reopening to avoid method redefinition warnings. Drop RR and Bacon gem dependencies. Also: rewrite README with table of contents, add GitHub Actions CI workflow (Ruby 3.1–3.4), migrate from EventMachine to async I/O, and fix Ruby 4.0 frozen string warnings in Response.
- Replace ListenerTestMock send_data/initialize overrides with a MockConnection object passed to .new, so the real send_data writes to the mock connection instead of being monkey-patched - Split test files to one test class per file - Move connection logic into Inbound.start/Outbound.start class methods - Standardize on parentheses in all method definitions - Update examples to match current API
Remove Base.self.new/allocate/post_init pattern inherited from EventMachine. Each class now uses a standard initialize that accepts connection as the first argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
spec/totest/, use*_test.rbsuffix andtest_helper.rbnaming.prependmodule (ListenerTestMock) instead of reopeningBaseclass and redefining methods. Configurableon_event_blockreplaces singleton method redefinitions.baconandrrgems, addminitest.attr_readerinstead ofattr_accessorinResponse(custom setters exist), eliminating method redefinition warnings.filtersAPI (wasfilter), removed stale links (IRC, mailing list, rdoc.info).CommandSocketspec.