Add branch/type filters to transitions and dict-based fixVersion mapping#460
Conversation
…rsion mapping, and tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…pe-filtered-transitions
|
/ok-to-test |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Thank you @webbnh, |
- Guard noisy log in update_transition when pr_updates is absent - Simplify base_branch extraction with dict reference instead of .get() - Split PR filter tests into separate units for _matches_transition_filters and update_transition - Add missing issue test scenarios: absent/empty issue_updates, none-match multiple entries, already-matching status, transition=True - Fix misleading "cumulative" comment in issue test docstring - Document branches, issue_types filters and dict-based fixVersion mapping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace `closed_status is not True` with `isinstance(closed_status, str)` to safely skip any non-string value (True, False, None, etc.) - Show branches/issue_types as keys in the same dict in pr_updates docs - Add test scenario for transition: False Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@webbnh ,Thanks for the detailed feedback! |
|
/ok-to-test |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ormalize transition True - Consolidate merge_transition and issue_updates transition doc entries into single entries showing optional filters, per reviewer suggestion - Fix mapping array description wording - Normalize legacy transition: True to "Closed" (confirmed by Ralph) - Update test expectation for True normalization Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for the review @webbnh , |
|
/ok-to-test |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…add malformed config warning Use CUSTOM_TRANSITION placeholder in pr_updates doc example for consistency, and log a warning when a non-string transition value is encountered in issue_updates config. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@webbnh , Any further changes needed? |
|
/ok-to-test |
|
Hi @ralphbean and @Zyzyx , |
|
/ok-to-test |
3 participants
Summary
branches(glob) andissue_typesfilters to PR transition configs, so transitions only fire for matching branches and Jira issue typesissue_typesfilter support to issue transition configsfixVersionmapping (in addition to existing string template format)base_branchfield to PR intermediary, extracted from GitHub PR payloadTest plan
_update_transitionwith issue_types filtering (7 scenarios)map_fixVersion(string template + dict lookup)Issue.from_github🤖 Generated with Claude Code