Skip to content

Fix assignee being cleared when upstream user has no fullname#480

Merged
Bala-Sakabattula merged 3 commits into
release-engineering:mainfrom
Bala-Sakabattula:assignment-fix
Jun 4, 2026
Merged

Fix assignee being cleared when upstream user has no fullname#480
Bala-Sakabattula merged 3 commits into
release-engineering:mainfrom
Bala-Sakabattula:assignment-fix

Conversation

@Bala-Sakabattula
Copy link
Copy Markdown
Collaborator

Summary

  • Fix a bug in _update_assignee() where an upstream GitHub assignee without a fullname in their profile would cause the downstream Jira assignee to be incorrectly cleared. The root cause was that us_exists checked for fullname (optional) instead of login (always present), so a valid assignee with no display name was treated as "no assignee", triggering a de-assignment.
  • When login exists but fullname is absent, assign_user() is now called to resolve the user via LDAP/email lookup rather than clearing the Jira assignee.
  • Expanded test_update_assignee_all with a new upstream variant (login present, no fullname key) and updated existing test data to include login fields, reflecting the corrected us_exists semantics.

webbnh

This comment was marked as resolved.

@Bala-Sakabattula
Copy link
Copy Markdown
Collaborator Author

@webbnh I made the changes as per suggestion.. can you kindly please review again??

Copy link
Copy Markdown
Collaborator

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread sync2jira/downstream_issue.py
@Bala-Sakabattula Bala-Sakabattula merged commit e67adf8 into release-engineering:main Jun 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants