Fixing extract_fbc_fragment#1334
Closed
lipoja wants to merge 38 commits into
Closed
Conversation
Co-authored-by: Yashvardhan Nanavati <yashn@bu.edu> Assisted-by: Gemini, Claude, Cursor [CLOUDDST-28644] [CLOUDDST-28865]
Co-authored-by: Jan Lipovský <jlipovsk@redhat.com> Assisted-by: Claude Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Co-authored-by: Yashvardhan Nanavati <yashn@bu.edu> [CLOUDDST-28644] [CLOUDDST-28865]
Co-authored-by: Yashvardhan Nanavati <yashn@bu.edu> [CLOUDDST-28644] [CLOUDDST-28865]
Co-authored-by: Jan Lipovský <jlipovsk@redhat.com> Assisted-by: Cursor Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Refers to CLOUDDST-28865 Assisted-by: Claude Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Assisted by: Gemini, Claude [CLOUDDST-28644]
Assisted by: Gemini [CLOUDDST-28644]
This will be done in iib-playbooks. [CLOUDDST-28644]
Refers to CLOUDDST-28865 Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu> Assisted-by: Cursor Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
This commit introduces a new function named `validate_bundes_in_parallel` on `containerized_utils` which performs a parallel validation of whether the bundles in a given list are present in the registry. THe function will wait for all the threads to complete by default, but it can return the list of threads for external waiting. Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Assisted-by: Cursor/Gemini
All handler functions perform some common operations like cloning the git repo, fetching index.db, pushing it and creating mrs. This commit extracts those into helper functions to avoid duplication of code. Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu> Assisted-by: Claude Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Refers to CLOUDDST-28866 Assisted-by: Claude Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Refers to CLOUDDST-28866 Assisted-by: Cursor Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
For some older versions like v4.12, OCP has stopped building the binary image for a couple of arches. Index image should follow suite. Include arches in the build metadata so the builder task can build the index image accordingly. Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu> Assisted-by: Cursor
Refers to CLOUDDST-29408 Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Assisted-by: Cursor/Gemini # Conflicts: # iib/workers/tasks/build_merge_index_image.py # and fixing unit tests [jlipovsk]
Update `api_v2` to use the `handle_containerized_merge_request` Refers to CLOUDDST-29408 Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Assisted-by: Cursor/Gemini
Refers to CLOUDDST-29408
This commit fixes the parallel validation class to validate the bundlePath from the bundles dictionary Refers to CLOUDDST-29408 Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Assisted-by: Cursor/Gemini
Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Refers to CLOUDDST-29387 Assisted-by: Claude Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Refers to CLOUDDST-29387 Assisted-by: Claude Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu> Assisted-by: Cursor
Assisted-by: JetBrains AI/Gemini [CLOUDDST-28643]
[CLOUDDST-28643]
Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu> Assisted-by: Claude
We can't use `podman rmi` inside containerized IIB. [CLOUDDST-31191]
This commit removes the limitation of the build to require all arches to be present in the binary image configuration. With this change it's possible to have a binary image which doesn't support all arches coming in the request and the request will only process the supported arches. Refers to CLOUDDST-28638 Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Assisted-by: Cursor/Gemini
This commit introduces a new configuration variable named `IIB_BINARY_IMAGE_LESS_ARCHES_ALLOWED_VERSIONS` which, when set, defines a list of OPM versions that are allowed to proceed building index images for lesser arches than the defaults, using the supported values from the configured binary image. It also updates the existing unit-tests Refers to CLOUDDST-28638 Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Assisted-by: Cursor/Gemini
Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu> Assisted-by: Cursor Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
… default in config.py Assisted-by: Cursor/ChatGPT [CLOUDDST-31191]
This commit changes the `get_oras_artifact` and `push_oras_artifact` to allow using a default Docker config.json, containing only credentials for the ORAS operations, whenever the following conditions are met: 1. The worker variables `iib_index_db_artifact_registry` and `iib_index_db_artifact_registry` are properly set with the registry URL and its pull/push secret. 2. The methods `[pull|push]_oras_artifact` are called without any value being set to the parameter `registry_auths`, forcing it to use the default value. It also adds unit-tests for this new change. Refers to CLOUDDST-32383 Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Assisted-by: Cursor/Gemini
This commit changes the `get_oras_artifact` and `push_oras_artifact` to allow using a default Docker config.json, containing only credentials for the ORAS operations when the `iib_index_db_oras_auth_path` is set. Refers to CLOUDDST-32383 Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Assisted-by: Cursor/Gemini
Extract data correctly and return path to config directory Assisted-by: Cursor/Composer
lipoja
force-pushed
the
fix_config_commits
branch
from
128926d to
4071d50
Compare
Contributor
Author
|
Targeted incorrect branch. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this moment IIB creates PR where
/config/operatoris copied to incorrect location/config/config/operatorThis PR is introducing a fix.
Extract data correctly and return path to config directory.