Conversation
Reviewer's GuideAdds repository-local guidance for AI coding assistants via CLAUDE.md, documenting project commands, architecture, and testing conventions, plus an AGENTS.md shim that points other AI tools to the same guidance. Class diagram for task system and cloud providersclassDiagram
class MarketplacesVMTask {
+run()
+parse_args()
+logger
}
class CombinedVMPush {
+run()
}
class MarketplacesVMPush {
+run()
}
class CommunityVMPush {
+run()
}
class VMDelete {
+run()
}
class CloudService {
+add_cloud_args(parser)
+get_cloud_provider(item)
}
class CollectorService {
+add_collector_args(parser)
+get_collector()
}
class StarmapService {
+add_starmap_args(parser)
+get_starmap_client()
}
class AwsRHSMClientService {
+add_rhsm_args(parser)
+get_rhsm_client()
}
class CloudCredentials {
<<frozen_attrs>>
+access_key
+secret_key
+subscription_id
+tenant_id
}
class CloudProvider {
<<abstract, generic T C>>
+publish_image(item)
+delete_image(item)
+credentials : CloudCredentials
}
class AWSProvider {
+publish_image(item)
+delete_image(item)
}
class AzureProvider {
+publish_image(item)
+delete_image(item)
}
MarketplacesVMTask <|-- CombinedVMPush
MarketplacesVMTask <|-- MarketplacesVMPush
MarketplacesVMTask <|-- CommunityVMPush
MarketplacesVMTask <|-- VMDelete
MarketplacesVMTask *-- CloudService
MarketplacesVMTask *-- CollectorService
MarketplacesVMTask *-- StarmapService
MarketplacesVMTask *-- AwsRHSMClientService
CloudProvider o-- CloudCredentials
CloudProvider <|-- AWSProvider
CloudProvider <|-- AzureProvider
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Collaborator
Author
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- AGENTS.md is currently added as a regular file containing the string
CLAUDE.md; if the intention is to have an actual symlink for tools that expect one, this should be committed as a filesystem symlink rather than a one-line text file.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- AGENTS.md is currently added as a regular file containing the string `CLAUDE.md`; if the intention is to have an actual symlink for tools that expect one, this should be committed as a filesystem symlink rather than a one-line text file.
## Individual Comments
### Comment 1
<location path="CLAUDE.md" line_range="80" />
<code_context>
+
+- 100% code coverage is enforced (`.coveragerc` `fail_under = 100`)
+- Tests use `requests-mock` for HTTP mocking, not live services
+- `tests/conftest.py` has session-scoped auto-use fixtures that set `PYTHONHASHSEED`, mock HOME, reset pushsource, and inject a `FakeCollector`
+- `CommandTester` (in `tests/command.py`) simulates CLI invocations by calling `entry_point()` directly
+- Test data fixtures live in `tests/data/`
</code_context>
<issue_to_address>
**suggestion (typo):** Consider changing "auto-use fixtures" to "autouse fixtures" to match pytest terminology.
Using pytest’s standard term "autouse fixtures" (without a hyphen) will be clearer to readers familiar with pytest.
```suggestion
- `tests/conftest.py` has session-scoped autouse fixtures that set `PYTHONHASHSEED`, mock HOME, reset pushsource, and inject a `FakeCollector`
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
Author
|
NOTE: depends on #147 to fix the CI |
CLAUDE.md provides guidance to Claude Code and other AI coding assistants working in this repository. It documents build/test/lint commands, code style rules, the task/mixin/step-decorator architecture, cloud provider patterns, and testing conventions (100% coverage, requests-mock, CommandTester, auto-use fixtures). AGENTS.md is a symlink to CLAUDE.md so that other AI tools that look for AGENTS.md find the same content. Refers to SPSTRAT-736 Signed-off-by: Jonathan Gangi <jgangi@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
suggestion (typo): Consider changing "auto-use fixtures" to "autouse fixtures" to match pytest terminology. Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE.md provides guidance to Claude Code and other AI coding assistants working in this repository. It documents build/test/lint commands, code style rules, the task/mixin/step-decorator architecture, cloud provider patterns, and testing conventions (100% coverage, requests-mock, CommandTester, auto-use fixtures).
AGENTS.md is a symlink to CLAUDE.md so that other AI tools that look for AGENTS.md find the same content.
Refers to SPSTRAT-736
Summary by Sourcery
Add repository-level guidance for AI coding assistants and expose it under a conventional filename for other tools to consume.
Documentation:
Chores: