Add Kafka messaging support#389
Merged
Merged
Conversation
hluk
force-pushed
the
kafka
branch
2 times, most recently
from
bc72c6a to
cd19c71
Compare
mvalik
reviewed
May 7, 2026
| KafkaException: If there's an error sending the message to Kafka. | ||
| """ | ||
| config, producer_config = _parse_config() | ||
| producer = Producer(producer_config) |
Contributor
There was a problem hiding this comment.
Would be better to use some existing instance of Producer instead of create a new one for each message.
Member
Author
There was a problem hiding this comment.
I've refactored the code - split the various message producers into sub-modules and added initialization code for (app.publisher = ...) with simpler message publishing code.
mvalik
reviewed
May 12, 2026
| producer_config = dict(config.producer) | ||
| username = os.environ.get("WAIVERDB_KAFKA_SASL_USERNAME") | ||
| password = os.environ.get("WAIVERDB_KAFKA_SASL_PASSWORD") | ||
| if username: |
Contributor
There was a problem hiding this comment.
Both credentials should be present or both should be considered missing if at least one is missing.
mvalik
reviewed
May 12, 2026
| ) | ||
|
|
||
| try: | ||
| config = KafkaConfig(**config_dict) |
Contributor
There was a problem hiding this comment.
Shadowing the original variable config
Introduce confluent-kafka publisher and unify all message publishers (kafka, stomp, fedmsg) behind a consistent app.publisher interface. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce confluent-kafka publisher and unify all message publishers
(kafka, stomp, fedmsg) behind a consistent app.publisher interface.
JIRA: RHELWF-13773
Assisted-by: Claude Opus 4.6 noreply@anthropic.com