Skip to content

fix: shorten APP_VERSION to 7-char git short SHA #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reloadfast merged 1 commit into from
Mar 2, 2026
Merged

fix: shorten APP_VERSION to 7-char git short SHA #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ jobs:
org.opencontainers.image.vendor=talesofthemoon
org.opencontainers.image.licenses=MIT

# ── Short SHA for version label ───────────────────────────────────────────
- name: Set short SHA
id: sha
run: echo "short=${GITHUB_SHA::7}" >> "$GITHUB_OUTPUT"

# ── Build and push per-arch digest ────────────────────────────────────────
# On PRs: build only (no push, no digest needed).
# On push/tag: push digest-only (no manifest tag) via outputs; the merge
Expand All @@ -97,7 +102,7 @@ jobs:
# On PRs: type=docker (local load, no push). On push/tag: digest-only push.
outputs: ${{ github.event_name != 'pull_request' && format('type=image,name={0},push-by-digest=true,name-canonical=true,push=true', env.IMAGE) || 'type=docker' }}
labels: ${{ steps.meta.outputs.labels }}
build-args: APP_VERSION=sha-${{ github.sha }}
build-args: APP_VERSION=${{ steps.sha.outputs.short }}
# Per-arch GHA cache (keyed by platform so they don't collide)
cache-from: type=gha,scope=${{ matrix.platform }}
cache-to: type=gha,mode=max,scope=${{ matrix.platform }}
Expand Down Expand Up @@ -136,6 +141,10 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Set short SHA
id: sha
run: echo "short=${GITHUB_SHA::7}" >> "$GITHUB_OUTPUT"

# Build the image locally for scanning (amd64 only — same OS layers as arm64)
- name: Build image for scanning
uses: docker/build-push-action@v6
Expand All @@ -145,7 +154,7 @@ jobs:
platforms: linux/amd64
load: true
tags: networkcrawler:scan
build-args: APP_VERSION=sha-${{ github.sha }}
build-args: APP_VERSION=${{ steps.sha.outputs.short }}
cache-from: type=gha,scope=linux/amd64

# Run Trivy — report CRITICAL/HIGH; results visible in Security tab without blocking merges
Expand Down
Loading