fix: native matrix + merge-manifests Docker build (replaces QEMU) - #22
Merged
Merged
Conversation
Build amd64 on ubuntu-latest and arm64 on ubuntu-24.04-arm in parallel, each pushing a per-arch digest. A final merge job assembles them into a single multi-arch manifest using docker buildx imagetools create. This reduces arm64 build time from ~30 min (QEMU emulation) to ~3-4 min (native runner). Also adds continue-on-error to the Hub description step to prevent a token scope issue from failing an otherwise successful build.
reloadfast
added a commit
that referenced
this pull request
Feb 27, 2026
Squash merge of #22 omitted this commit. Applying directly to main. Setting push: true alongside outputs with push-by-digest=true caused the action to attempt a tagged push with no tag, triggering insufficient_scope on Docker Hub. name=target was a literal placeholder; replaced with the actual image name via format().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The existing
docker.ymlbuilt bothlinux/amd64andlinux/arm64in a single job using QEMU emulation. QEMU arm64 emulation on a Node+Python multi-stage image takes 30+ minutes on free GitHub runners, making the build effectively unusable.Solution
Replace with the matrix + merge-manifests pattern:
buildjob (matrix) — two runners in parallel:linux/amd64onubuntu-latestlinux/arm64onubuntu-24.04-arm(GitHub's native ARM runner)Each runner builds its arch natively, pushes a digest-only image, and uploads the digest as an artifact.
mergejob — waits for both builds, downloads the digest artifacts, then callsdocker buildx imagetools createto assemble a single multi-arch manifest with all final tags (:latest,:<sha>, semver).Other changes
continue-on-error: trueadded to the Docker Hub description step — a token scope issue on the previous main-branch push caused that step to fail even though the image built successfully.scope=linux/amd64/scope=linux/arm64) so the caches don't overwrite each other.packages: writepermission removed (was kept speculatively for GHCR, not needed for Docker Hub).Expected outcome
talesofthemoon/networkcrawler:latestmanifest covers both architectures