[Phase 2] SQLite device inventory (SQLAlchemy models) - #23
Merged
Merged
Conversation
…ints, upsert helpers - Device: add vendor column (arp-scan OUI lookup), UniqueConstraint on ip_address - Port: add UniqueConstraint on (device_id, port_number, protocol) - db.py: add upsert_device() and upsert_port() helpers — insert-or-update keyed on ip_address and (device_id, port, proto) respectively; None fields never overwrite existing data - Tests: 20 tests covering schema, CRUD, constraint enforcement, upsert create/update/idempotency/none-does-not-overwrite; total suite 57 tests at 99% Closes #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Changes
backend/app/models/device.pyDevice: addedvendorcolumn (populated from arp-scan OUI lookup),UniqueConstraint("ip_address")— one row per IP, upserts update in placePort: addedUniqueConstraint("device_id", "port_number", "protocol")— prevents duplicate port rows per device per scanbackend/app/db.pyupsert_device(session, *, ip_address, mac_address, vendor, hostname, os_guess)— inserts a new Device or updates non-None fields on an existing one; never overwrites stored data with Noneupsert_port(session, *, device_id, port_number, protocol, service_name, version_banner)— same pattern for Port rowsbackend/tests/test_db.py