feat: show affected device identity on risk cards (#40) - #43
Merged
Merged
Conversation
- Add ip_address and hostname fields to RiskOut schema - Eagerly load Risk.device via selectinload in list/get/device_risks queries - Risk list rows and modal now show hostname (or IP) as a clickable link - Remove N+1 client-side device lookup from RisksPage Closes #40 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40
Changes
Backend —
backend/app/api/__init__.pyip_addressandhostnamefields toRiskOutschemalist_risks,get_risk,device_risks) to eagerly loadRisk.deviceviaselectinload— eliminates N+1 queriesFrontend —
frontend/src/types/api.tsip_address: stringandhostname: string | nullto theRiskinterfaceFrontend —
frontend/src/pages/RisksPage.tsxhostname(preferred) orip_addressas a clickable link to/devices/:iddevices.find(...)in the list)Tests —
backend/tests/test_api.pytest_risk_schema_fieldsto assertip_addressandhostnamekeys are presenttest_risk_includes_device_identityassertingip_addressmatches the seeded device