fix: severity URL param, API validation, and json.loads guard - #56
Merged
Merged
Conversation
…#48) #46 — RisksPage reads initial severity filter from URL search params: - Import useSearchParams from react-router-dom - Initialise sevFilter from ?severity= query param on mount - Validate against SEVERITIES allowlist to prevent invalid state - Navigating to /risks?severity=critical now pre-filters the list #47 — Validate severity query param in /api/risks: - Change severity param type from str|None to Literal[critical|high|medium|low]|None - FastAPI/Pydantic now returns 422 on invalid values instead of silent empty list #48 — Guard json.loads in recommendations endpoint: - Add _safe_load_steps() helper that wraps json.loads in try/except - Empty/falsy steps returns [] gracefully - Malformed JSON logs a warning and returns [] instead of 500 - Added logging import alongside existing json import - Tests: 422 on invalid severity, malformed steps returns [], empty steps returns [] Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Sort deferred imports (app before sqlalchemy) to satisfy I001
- Replace __import__('sqlalchemy') with explicit import to satisfy E501
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46, Closes #47, Closes #48