Make NDC target emissions scope independent of multigasscen switch and do some further clean up of NDC realization - #2447
Open
fschreyer wants to merge 12 commits into
Open
Make NDC target emissions scope independent of multigasscen switch and do some further clean up of NDC realization#2447fschreyer wants to merge 12 commits into
fschreyer wants to merge 12 commits into
Conversation
added 12 commits
August 19, 2026 21:21
… GHG excl LULUCF and excl bunkers independent of the multigasscen switch
…ts NDC emissions target algorithm
…ss fast to ease NDC target convergence and make upper limit and lower limit generally more transparent by saving them into parameters over iterations
RahelMA
requested changes
Aug 28, 2026
RahelMA
left a comment
Contributor
There was a problem hiding this comment.
Thank you, Felix, I'm not entirely done with you PR just note that we need p45_CO2eqwoLU_goal in the preloop!
Contributor
There was a problem hiding this comment.
I would argue we cannot remove this as we need the BAU data to calculate the NDC goal in the first place:
p45_CO2eqwoLU_goal(p45_NDCyearSet(t,regi)) =
p45_EmiTargetAbs(t,regi) !! emissions target derived from countries with NDC target
+ (1-p45_shareTarget(t,regi)) * p45_BAU_reg_emi_wo_LU_wo_bunkers(t,regi);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR addresses https://github.com/remindmodel/development_issues/issues/794 and does some clean-up of the NDC code.
These are the changes:
cm_multigasscen-> as NDC-LTS uses different multigasscen setting this led to wrong results in this scenario before (too ambitious NDC targets)p45_factorRescaleUpLimitetc. parameters to track when rescaling is cappedType of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)