Fix API demo build test file exclusion#11614
Open
markdalgleish wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/736eb933-67ae-479f-9645-77d52ca85a90
Contributor
Preview Build AvailableA preview build has been created for this PR. You can install it using: pnpm install "remix-run/remix#preview/pr-11614&path:packages/remix"This preview build will be updated automatically as you push new commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API demo build already tries to avoid copying test files into
api/build/demos, but the existing check only excludes files ending in.test.ts. That means test files ending in.test.tsx,.test.e2e.*and.test.browser.*can still be copied over and break the root-levelremix testrun.This PR updates the existing exclusion to cover the full Remix test filename pattern:
*.test.ts*.test.tsx*.test.browser.ts*.test.browser.tsx*.test.e2e.ts*.test.e2e.tsx