fix(headers): anchor SameSite value regex#11615
Open
jokull wants to merge 2 commits into
Open
Conversation
The SameSite check used /strict|lax|none/i as a substring test, so any
value containing one of those words was accepted and capitalized:
new SetCookie('id=a; SameSite=nonesense').sameSite // "Nonesense"
new SetCookie('id=a; SameSite=strictly').sameSite // "Strictly"
Both violate the declared 'Strict' | 'Lax' | 'None' type and
re-serialize verbatim. Anchoring the regex makes invalid values fall
through to undefined, matching how other malformed attributes are
handled.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetCookiematches theSameSiteattribute value with/strict|lax|none/i— a substring test — and then capitalizes whatever it got, so any value containing one of those words is accepted and re-serialized:Both values violate the declared
'Strict' | 'Lax' | 'None'type and round-trip verbatim (id=a; SameSite=Nonesense)./^(strict|lax|none)$/iso invalid values fall through toundefined, consistent with how malformedExpiresandMax-Ageare handledSameSite=lax,SameSite=STRICTstill normalize)🤖 Generated with Claude Code