fix: sync RailwayClass enum with RailAccessParser Set#5
Merged
Conversation
These two data structures need to stay in sync so that the rail routing service operates as expected. The values in `RailwayClass` are used for styling the ways The values in `RailAccessParser` are used for routing over those ways. Summary of changes: - `NARROW_GAUGE` - removed - `MONORAIL` - added - `PROPOSED` - added
brookeangel
reviewed
Dec 23, 2024
| parser.handleWayTags(edgeId, edgeIntAccess, way, relFlags); | ||
| assertEquals(RailwayClass.PROPOSED, classEnc.getEnum(false, edgeId, edgeIntAccess)); | ||
|
|
||
| edgeIntAccess = new ArrayEdgeIntAccess(1); |
There was a problem hiding this comment.
Are these tests that came with open rail routing? I don't find them particularly readable 😅 are they just asserting that the values exist in the enum?
Collaborator
Author
There was a problem hiding this comment.
yeah, they mostly came with the project. We added some additional ones as well. The test is actually exercising the class and making expectations on the output based on the inputs.
brookeangel
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two data structures need to stay in sync so that the rail routing service operates as expected.
The values in
RailwayClassare used for styling the ways The values inRailAccessParserare used for routing over those ways.Summary of changes:
NARROW_GAUGE- removedMONORAIL- addedPROPOSED- added