fix(modify):stop modified array item fields being added to schema when missing in original schema

[remotecom]

Pull Request

Summary

Stop merging fields..items into the schema when the target doesn’t exist. Item-level changes are applied only to existing array item schemas and only to existing properties, so conditionally omitted fields are no longer added. Adding new structure remains the responsibility of consumers (e.g. via the create property).

Changes Made

• src/modify-schema.ts

  • No blind merge of items: items is removed from the object that gets merged into the field, so it's never merged in as a top-level attribute.
  • Item changes only when structure exists: When fieldChanges.items is set, the code only applies it when fieldAttrs.items is a single existing item schema (object, not tuple). It then merges item-level attributes and runs rewriteFields for items.properties on that existing item schema, so only existing item properties are modified; properties that don't exist in the original schema are not added.

• test/modify-schema.test.ts

  • New test that adding a property under fields.<arrayPath>.items.properties that doesn't exist in the original item schema does not add it to the final schema.

Related Issues/PRs

None.

Screenshots (Before/After if applicable)

N/A.

Checklist

• I have read the Contributing Guidelines and followed them.
• Unit tests were added.

---

Note

Medium Risk
Changes core modifySchema merge behavior for array items, which could alter existing customizations that relied on the previous (more permissive) merge semantics. Scope is limited and covered by new tests, but it affects schema mutation logic used across consumers.

Overview
Fixes modifySchema so config.fields.<arrayPath>.items is no longer blindly merged into the field schema, preventing accidental addition of new items structure/properties when they weren’t present in the original schema.

Adds targeted handling to apply items mutations only when the array has an existing single item schema object, and to rewrite items.properties using the same “modify-only-if-exists” behavior. New unit tests cover updating existing array item properties and ensuring missing item properties are ignored rather than created.

^{Written by Cursor Bugbot for commit f47e576. This will update automatically on new commits. Configure here.}

[danielcardoso5]

Just two nits, approving, but can approve again once updated!

[ricardojoaomestre]

@danielcardoso5 I've addressed your comments. We're good to go 👍