fix: stop ignoring tracked source and docs directories - #40
Open
rodrigottv wants to merge 1 commit into
Open
Conversation
Several .gitignore rules covered directories whose contents are tracked. Git keeps tracked files working, so nothing was visibly broken — but a NEW file in those directories is silently skipped by `git add`, with no error. - `tests/` — the 7 test files are tracked and CI runs `npm test` over them, so a new test file would pass locally and never reach the repository. Added by 7c6c370 ("update ignore patterns"), which over-reached. - `docs/` — ignored since the initial commit, yet 48 design docs are tracked and new ones are still being committed (8be326c, 85c74fa, 07e78cc), so the rule has been worked around rather than honoured. CLAUDE.md points here. Also: - `dashboards/test-results/` was a typo — the directory is `dashboard/` (singular), so the rule matched nothing while the real path went uncovered. - `temp/squads/` was redundant with `temp/`. `temp/`, `test-results/` and `dashboard/test-results/` stay ignored: they are scratch and build-artifact directories, where silently skipping new files is the desired behaviour. Their already-tracked contents are unaffected. Verified by probing a new file in each directory: tests/ and docs/ now accept one, the artifact directories still reject it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39, where I hit this while committing and flagged it as out of scope.
The problem
Several
.gitignorerules cover directories whose contents are tracked. Git keeps tracked files working, so nothing looks broken — but a new file in those directories is silently skipped bygit add, with no error and no warning.tests/docs/temp/test-results/squads/*/.claude/settings.local.jsonWhat this changes
Removed
tests/— the 7 test files are tracked and CI runsnpm testovertests/*.test.js. A new test file would pass locally and never reach the repository, so the suite would silently stop growing. This rule came from 7c6c370 ("update ignore patterns"), which over-reached.Removed
docs/— ignored since the initial commit, yet 48 design docs are tracked and new ones are still being added (8be326c,85c74fa,07e78cc). The rule has been worked around rather than honoured, andCLAUDE.mdpoints readers here.Fixed a typo —
dashboards/test-results/(plural) matched nothing; the directory isdashboard/(singular), so the real path was never covered.Removed
temp/squads/— redundant withtemp/.What this deliberately leaves alone
temp/,test-results/anddashboard/test-results/stay ignored. They are scratch and build-artifact directories, where silently skipping new files is the behaviour you want. Their already-tracked contents are unaffected either way.squads/*/stays — ignoring user-created squads is correct; the trackedstate.jsondashboard fixtures predate the rule and keep working.Verification
Probed a new file in each directory:
No previously-hidden files appear in
git statusas a result, so this exposes nothing unintended.One thing I did not touch
.claude/settings.local.jsonis both ignored and tracked — the inverse of the above. Because it is tracked, every contributor's local permission edits show up as repository modifications (this happened to me while working on #39). The clean fix isgit rm --cached, but that removes the file for everyone and contributors would lose whatever shared permission baseline it provides. That is your call, not mine, so I left it.🤖 Generated with Claude Code