Skip to content

Unblock the v0.2.4 release gates #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rengwu merged 2 commits into from
Aug 20, 2026
Merged

Unblock the v0.2.4 release gates #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74b8c2f
fix: keep AppImage smoke script parseable
rengwu Aug 20, 2026
005044c
fix: unblock the two release steps RC1-3 never reached
rengwu Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ jobs:
- name: Static checks (go vet + svelte-check)
run: make check

- name: Shell script syntax
run: bash -n scripts/*.sh

- name: Go tests
run: make test

Expand Down
14 changes: 13 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,22 @@ jobs:
shell: bash
run: |
set -e
# upload-artifact roots the artifact at the common ancestor of its
# path globs, so the download arrives split across appimage/ and
# packages/ rather than flat. v0.2.3 shipped with no Linux assets at
# all because of that: every `ls` below missed, every arch was
# skipped without complaint, and the upload then choked on a
# directory in its glob. Flatten first, and fail loudly on a miss.
find linux-desktop -mindepth 2 -type f -exec mv -t linux-desktop {} +
find linux-desktop -mindepth 1 -type d -empty -delete
for arch in amd64 arm64; do
for extension in AppImage deb rpm; do
versioned=$(ls linux-desktop/chartr_*_linux_${arch}.${extension} 2>/dev/null | head -1) || true
[ -n "$versioned" ] || continue
if [ -z "$versioned" ]; then
echo "no chartr_*_linux_${arch}.${extension} among the built artifacts:" >&2
ls -R linux-desktop >&2
exit 1
fi
alias="linux-desktop/chartr_linux_${arch}.${extension}"
cp "$versioned" "$alias"
( cd linux-desktop && sha256sum "chartr_linux_${arch}.${extension}" > "chartr_linux_${arch}.${extension}.sha256" )
Expand Down
2 changes: 1 addition & 1 deletion scripts/smoke-appimage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ docker run --rm -v "$(realpath "$APPIMAGE")":/chartr.AppImage:ro "$IMAGE" bash -
fail "WebKit reported an internal error"
fi

# The X11 identity is the runtime half of desktop integration. GTK's resource
# The X11 identity is the runtime half of desktop integration. The GTK resource
# name is lowercase and its resource class is conventionally title-cased;
# StartupWMClass uses the latter so a real desktop resolves the bundled icon.
# Bare Xvfb has no window manager, so _NET_WM_ICON is diagnostic only here.
Expand Down
5 changes: 4 additions & 1 deletion scripts/smoke-native-package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ docker run --rm \
test -x /usr/bin/chartr
test -f /usr/share/applications/io.github.rengwu.chartr.desktop
test -f /usr/share/metainfo/io.github.rengwu.chartr.metainfo.xml
test -f /usr/share/icons/hicolor/512x512/apps/chartr.png
# The icon bands ship as SVG masters (ADR 0016), not a single 512 PNG.
test -f /usr/share/icons/hicolor/16x16/apps/chartr.svg
test -f /usr/share/icons/hicolor/32x32/apps/chartr.svg
test -f /usr/share/icons/hicolor/scalable/apps/chartr.svg
chartr --version | grep -F "chartr shell ${EXPECTED_VERSION} "

export XDG_RUNTIME_DIR=/tmp/xdg
Expand Down
Loading