Repository navigation
Conversation
|
Thanks, I read through it. The API shape is good: the options tail keeps the ABI-1 prefix, 0.1.66 keeps working because it only checks A few things before it can go in:
#1098 and #1108 also rebuild the base. Whichever merges last regenerates it, so expect to run Generated by Claude Code |
|
Thanks, this covers my points:
On the rollback: a first The only thing left from my list is the base update: these runs RAM-booted the base and nothing was flashed. I'll run that update on my unit myself once I'm back from holiday, before I merge, so please mark it ready for review. #1098 and #1007 also rebuild the base. Whichever of them merges after this one regenerates the base, so Generated by Claude Code |
|
A question for after this merges, not a blocker for it. Beat Slicer is USB-only because card firmware has no base: A card form could be built the way MIDI generators do it without the base. On card builds only, Beat Slicer would link its own copy of the sample-editor service, including this PR's SNAP addition, and patch the service's five stock sites itself. Over USB it would keep using the base's service. That would need:
It reintroduces the per-module patching that
Whichever you choose, 0.1.68 would ship USB-only, and any card form would come as its own later release. Generated by Claude Code |
|
Thanks for asking first. Let's keep Beat Slicer USB-only (1). A card form carried by the module would bring back the per-module patching of the five sample-editor sites, which is exactly what the base's service is there to own, and it would add a card-only One thing on this PR: main has regenerated the base since your last merge, so it now conflicts in |
Regenerated the beta base with npm run octatrack:base -- --beta --write. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
npm run octatrack:module-packages -- --base-only --stock OS.bin: only requiredBase and Recorder Loop Fix's linked bytes moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged Guides: one gap. A local base build needs Generated by Claude Code |
What was hard
Beat Slicer 0.1.68 needs SNAP-aware grid alignment in the Octatrack sample editor. The shared editor service did not expose it, and the SLICE GRID shortcut needs to cycle safely through installed module actions.
What this changes
Adds an optional SNAP alignment mode to the sample-editor API while preserving the ABI-1 prefix and existing non-SNAP behavior. The beta base passes FUNC+AED from stock SLICE GRID through registered grid actions in order and back to stock; with no actions it stays stock. Actions retire their editor token on FUNC/AED before passing the key through. The guide and changelog describe the behavior beta testers receive when this base is deployed. The shared-base change does not itself publish Beat Slicer 0.1.68.
How I checked it
efab14e5…, the frontend trialled the usual 17 modules plus published Beat Slicer 0.1.66. The device self-test passed: 18/18 intact and 7/7 DSP effects exercised, zero failures. Whole-set Undo first returnedneeds-recovery; retry 17 succeeded and a fresh status confirmed the original beta-base active digest and empty baseline. The reason for the recovery responses was not established.195d2b46…produced a grid with SNAP OFF and another with SNAP ON; the author reports both completed normally. Each single-module trial was Undone and the beta base's empty baseline verified. These reports do not establish exact boundaries, audible output or persistence.npm run pr:ready -- --remote upstream: Ready after merging upstream main; 2,799 tests passed and one skipped, with SDK checks, lint, typecheck and build passing.[0, 22061, 44111, 66161, 88211, 90000]over 144 pair reads. The author listened and reported no audible problems. This is one alignment case, not general release or persistence qualification.Guides and remaining review
The sample-editor guide lacked the SNAP contract and FUNC+AED cycle, including token retirement. Updated
sdk/machines/octatrack/SAMPLE_EDITOR.mdand the dated changelog; the guide records both hardware trials and their limits. No firmware or stock image is committed.The earlier stalled full-set Undo remains unexplained. #1098 is still open and rebuilds the base; rerun
pr:readyand reassess exact-build evidence if that merge changes this base. #1108 closed without merging. Keep this PR in draft while the rollback concern is reviewed.Related to #1056.