Repository navigation
Fix: published-package test counts only site-event hook words past the four UI handlers - #1301
Merged
Merged
Conversation
…e four UI handlers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
repeat98
enabled auto-merge
November 7, 2026 14:26
Owner
|
Thanks Diego, that's right. Since #1231, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/engine/elekloader/module-set.test.tstreats any hook words in a published package as site events:view.getUint32(20) > 0must match features bit 128. Since Fix: publish an Octatrack C module with no event subscriptions over USB (ABI 8, named) #1231,npm run octatrack:module-packagesrepacks a C package with no events as ABI 8 (titled()). That package keeps its UI handler words (module_tick,module_draw,module_key,module_enc) and subscribes to nothing. The builder gives it features 0, which is correct:module_packages.pysets 128 only for hook words past the first four. The test then fails for the first such package, Tiempos (Tiempos 0.1.0-experimental: time left on all eight tracks (USB only) #1096: 4 hook words, features 0).> 4), as the builder does, and gets a changelog entry. No package, builder or site code changes.npx vitest run src/engine/elekloader/module-set.test.tson this branch: 61/61 pass. Every published package onmainfits the new rule: the ones with bit 128 have 5 to 37 hook words, and every other one has 0. On the Tiempos branch, with Tiempos's package added, the full suite passes this test; its only other failures are the date-dependentPageTraffic/community-activitytests andspectruminmodule-doctor.test.mjs, which fail the same way onmain. I did not runnpm run pr:readyon this branch.Related to #1096
🤖 Generated with Claude Code