Repository navigation
Upgrade classgraph from 4.8.198 to 5.0.0 - #858
Conversation
ClassGraph 5 no longer scans anything unless a source is enabled explicitly, so call enableClasspath() for both the directory listing and the scanJars scan. ClassInfoList.loadClasses() was removed; load the scanned classes via Class.forName without initializing them, like the directory scan already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Summary
io.github.classgraph:classgraph4.8.198 → 5.0.0.enableClasspath(),getClasspathFiles()returns an empty list and theplay.classes.scanJarsscan finds no classes, so controllers in scanned jars fail with "action not found". AddedenableClasspath()to both calls inJavaClassesScanner.ClassInfoList.loadClasses()was removed in 5.0. Scanned classes are now loaded withClass.forName(name, false, contextClassLoader), the same way the directory scan does it, and still without initializing them.6.0.0 was not used because it is compiled for Java 25 (class file version 69) and RePlay targets Java 17.
Test plan
./gradlew check./gradlew uitest(netty3, netty4, javanet). Before theenableClasspath()fix,multi-module-appfailed 3 tests.🤖 Generated with Claude Code
Summary by CodeRabbit