Ensure LFRCNP path uses actual traversed edges - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LFRCNP filtering was working during A* but we rebuilt the edge list from node pairs, so when two edges shared the same endpoints (e.g., secondary plus service), we sometimes reported the wrong one. I changed bounded_astar to remember (prev_node, edge_idx) and return the exact edges it traversed, wired find_best_path to use those edge indices directly, and deleted the node-pair reconstruction. Added a regression test ensuring parallel edges respect the LFRCNP limit.
All rust tests pass (cargo test --lib), and decoding C7yZ2hu9mhtvFAAH+8sbEA== now uses the correct secondary edge (12651516791334743440).