Skip to content

Surface active workspace in titlebar - #415

Open
majormel wants to merge 6 commits into
repoprompt:mainfrom
majormel:feature/411-active-workspace-in-titlebar
Open

Surface active workspace in titlebar#415
majormel wants to merge 6 commits into
repoprompt:mainfrom
majormel:feature/411-active-workspace-in-titlebar

Conversation

@majormel

@majormel majormel commented Jul 7, 2026

Copy link
Copy Markdown

Summary

  • Adds a prominent top toolbar workspace picker that shows the active workspace name across the main window.
  • Reuses the existing workspace picker switching behavior and adds a direct Create Workspace... action from the new top control.
  • Fixes the create-workspace sheet flow so a newly created workspace is switched to once instead of being created twice.

Screenshots

Zero-workspace state

The titlebar displays No Workspace when no workspace is active

Active workspace and chat title

The titlebar displays the active backchannel workspace and chat title

Workspace switcher

The titlebar workspace picker lists saved workspaces and create and manage actions

Why

Issue #411 calls out that the active workspace identity is easy to miss when users switch between multiple workspaces. The top toolbar now keeps that identity visible at a glance and provides quick switch/create/manage actions from the same place.

Validation

  • make dev-format
  • make dev-swift-build PRODUCT=RepoPrompt
  • make dev-lint
  • .agents/skills/rpce-contribution-check/scripts/preflight.sh commit
  • .agents/skills/rpce-contribution-check/scripts/preflight.sh push

Closes #411

@provencher

Copy link
Copy Markdown
Contributor

Add a screenshot for big visual changes like this

@majormel
majormel marked this pull request as ready for review July 7, 2026 23:10
@majormel
majormel force-pushed the feature/411-active-workspace-in-titlebar branch from f86e5c1 to e6a9c0b Compare July 14, 2026 17:28

@baron baron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new control does not visibly render the active workspace name required by #411. ActiveWorkspaceToolbarPicker computes workspaceTitle, but its visible label renders Text(title) (the Agent chat title); workspaceTitle is used only for accessibility. Please render the workspace name visibly or define an unmistakable composite presentation, add the requested screenshot and focused switching/zero/one-workspace coverage, then resolve conflicts and rerun CI.

@majormel
majormel requested a review from baron August 13, 2026 19:43

morluto commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Audit disposition — merge candidate after UI smoke (2026-08-14)

Keeping the active workspace visible in the titlebar is useful, and the create flow appears to fix the duplicate-create/switch behavior by switching to the object that was actually created. I did not find a code-level blocker in the focused change.

Before merge, refresh/exact-head CI and manually verify the zero-workspace state, long names in a narrow titlebar, rapid workspace switches, multi-window independence, and that Create Workspace creates and activates exactly one record.

morluto commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Deep-review assessment — 2026-08-14

Disposition: merge candidate after final UI/current-head checks. Keeping the active workspace visible in the titlebar addresses the stated discoverability problem, and switching to the already-created workspace object fixes the duplicate-create flow without introducing a second creation authority. I did not find a structural blocker.

Please validate long workspace names and narrow windows, rapid cross-window workspace switching, zero-workspace state, and that Create Workspace produces and activates exactly one workspace under repeated/slow sheet completion. With exact-head CI and a non-author review, this is an appropriately scoped UI change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surface the active workspace name prominently at the top of the main window

4 participants