Surface active workspace in titlebar - #415
Conversation
|
Add a screenshot for big visual changes like this |
f86e5c1 to
e6a9c0b
Compare
baron
left a comment
There was a problem hiding this comment.
The new control does not visibly render the active workspace name required by #411. ActiveWorkspaceToolbarPicker computes workspaceTitle, but its visible label renders Text(title) (the Agent chat title); workspaceTitle is used only for accessibility. Please render the workspace name visibly or define an unmistakable composite presentation, add the requested screenshot and focused switching/zero/one-workspace coverage, then resolve conflicts and rerun CI.
Audit disposition — merge candidate after UI smoke (2026-08-14)Keeping the active workspace visible in the titlebar is useful, and the create flow appears to fix the duplicate-create/switch behavior by switching to the object that was actually created. I did not find a code-level blocker in the focused change. Before merge, refresh/exact-head CI and manually verify the zero-workspace state, long names in a narrow titlebar, rapid workspace switches, multi-window independence, and that Create Workspace creates and activates exactly one record. |
Deep-review assessment — 2026-08-14Disposition: merge candidate after final UI/current-head checks. Keeping the active workspace visible in the titlebar addresses the stated discoverability problem, and switching to the already-created workspace object fixes the duplicate-create flow without introducing a second creation authority. I did not find a structural blocker. Please validate long workspace names and narrow windows, rapid cross-window workspace switching, zero-workspace state, and that Create Workspace produces and activates exactly one workspace under repeated/slow sheet completion. With exact-head CI and a non-author review, this is an appropriately scoped UI change. |
Summary
Create Workspace...action from the new top control.Screenshots
Zero-workspace state
Active workspace and chat title
Workspace switcher
Why
Issue #411 calls out that the active workspace identity is easy to miss when users switch between multiple workspaces. The top toolbar now keeps that identity visible at a glance and provides quick switch/create/manage actions from the same place.
Validation
make dev-formatmake dev-swift-build PRODUCT=RepoPromptmake dev-lint.agents/skills/rpce-contribution-check/scripts/preflight.sh commit.agents/skills/rpce-contribution-check/scripts/preflight.sh pushCloses #411