Preserve dirty Copy and Chat overlays during Agent Models changes

[baron]

Summary

• stop direct Agent Models changes from broadcasting the broad workspace-scoped recommendationsDidApply notification
• rely on the scoped agentModelsSettingsDidChange propagation path
• add a regression test proving dirty Copy and Chat window overlays remain intact

Review

• planned with a dedicated worktree implementer
• consulted Fable after planning
• consulted Fable again after implementation; review feedback was applied
• publication commit was recreated exactly on current origin/main while preserving the reviewed source/test blobs

Validation

• GlobalSettingsCrossWindowPropagationTests: 4 tests, 0 failures on current main
• make dev-lint: passed; SwiftFormat check reported 0/1456 changes and strict SwiftLint passed
• mandatory commit and push preflights: passed, including guardrails and outgoing-range secret scan
• git diff --check: clean

Validation boundary

A monolithic local pr-ready root lane on the earlier base hit the 3600-second limit in unrelated codemap suites. The publication branch was refreshed to current main, where the focused regression and lint are green. Please require exact-head hosted merge-ref CI before merge.

Live/debug app validation is intentionally deferred for this source-only fix.

[baron]

Triage: this is a small code-ready fix with green exact-head checks and a clean current-main textual merge. Because I am the author, I cannot self-approve. Please obtain a non-author exact-head review and current-base confirmation; prioritize after #767/#735.

[baron]

Current-main recheck on exact head 1ad217db0619c0b5904450036431b5c67b82b9ee: the substantive Swift change still has merit, but the branch now conflicts where it modifies the test-suite ledger that current main deleted. Please refresh the branch while retaining main's ledger deletion, rerun required CI, and obtain a non-author exact-head approval. This is a refresh hold, not a closure recommendation.

[morluto]

Audit disposition — refresh hold, not a closure recommendation (2026-08-14)

The substantive change is focused and appears correct: a direct Agent Models commit should publish through agentModelsSettingsDidChange, not broadcast the broader recommendationsDidApply event that can overwrite unrelated dirty Copy/Chat overlays. The regression exercises the right user-state boundary.

The branch needs to be refreshed while retaining current main’s deletion of the old test-suite ledger changes, followed by exact-head CI and a non-author review. I did not find a reason to discard the Swift fix itself.

[morluto]

Deep-review assessment — 2026-08-14

Disposition: good narrow fix; refresh the branch and obtain current-head review. Direct Agent Models commits should use the scoped agentModelsSettingsDidChange authority rather than broadcasting the broader recommendationsDidApply event, which can replace unrelated dirty Copy/Chat overlays. The focused regression establishes the important state-preservation contract.

I did not find a code-level blocker. Please refresh while retaining current main’s test-ledger deletion, rerun hosted merge-ref CI, and obtain a non-author exact-head review. This should remain a small propagation-domain correction rather than absorb broader settings changes.