Fix api doc page not scrollable#1180
Open
lungarella-raffaele wants to merge 1 commit intorescript-lang:masterfrom
Open
Fix api doc page not scrollable#1180lungarella-raffaele wants to merge 1 commit intorescript-lang:masterfrom
lungarella-raffaele wants to merge 1 commit intorescript-lang:masterfrom
Conversation
Collaborator
|
I think some of this, or all of this, is fixed by: #1156 @fhammerschmidt mentioned another issue, but I think it's best to try and get that merged in before any other scrolling or layout fixes. |
Member
|
Yeah but only if you dont introduce new layout issues check my last comment) |
Collaborator
|
I closed out the other PR, so I think we should go ahead with this fix. @lungarella-raffaele if you pull from master I think we should be able to have a cloudflare preview run so we can test things. |
15f620f to
0d25b9a
Compare
Contributor
Author
|
Let me know if I can do something to fix the build :) |
Collaborator
It's a permission issue on the GitHub action and some missing env variables that aren't accessible by forks. I feel like we should be able to figure it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #1162
This addresses a sidebar state management issue where the scrollbar behavior and sidebar state aren't properly coordinated.
I think the intended behavior should be:
However, the current implementation has some issues:
isSidebarOpenflashes fromtruetofalseeven when the sidebar is clearly visiblescrollLockandisSidebarOpenon all screen sizes, even though this behavior should only apply to mobile (I think)I've updated the logic so that sidebar state management primarily matters on mobile, with the sidebar defaulting to open on larger screens, but I had to add an hook to check if we are on mobile with an hardcoded breakpoint
This makes the docs more usable, but I'd love feedback on how to improve it! 🙂