Speed up npm install step on Linux ARM runners#1098
Open
mediremi wants to merge 2 commits intorescript-lang:masterfrom
Open
Speed up npm install step on Linux ARM runners#1098mediremi wants to merge 2 commits intorescript-lang:masterfrom
npm install step on Linux ARM runners#1098mediremi wants to merge 2 commits intorescript-lang:masterfrom
Conversation
Member
Author
mediremi
commented
May 20, 2025
| } | ||
|
|
||
| @genType | ||
| let testForwardRef = React.forwardRef(makeWithRef) |
Member
Author
There was a problem hiding this comment.
I wasn't able to port any of the React.forwardRef examples to v11, but since it's always been discouraged and with React v19 allowing refs as props anyway I guess it's fine
| 6 parseListO$loop<f>: [+Parser.next; _ || switch f {some: parseListO$loop<f:f>, none: _}] | ||
| 7 testAlwaysReturnNone: alwaysReturnNone | ||
| 8 thisMakesNoProgress: None; [_ || +Parser.next; Some] | ||
| 1 alwaysReturnNone: [_ || None] |
Member
Author
There was a problem hiding this comment.
Is termination analysis being broken/different for v11 expected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm citypically takes ~10s, but forubuntu-24.04-armit can take up to 10 minutes.By using
npm i --timing, I managed to pinpiont the source of the issue toanalysis/reanalyze/examples/deadcodeandanalysis/reanalyze/examples/termination.These folders were using ReScript v10, and for some reason its postinstall script takes much longer on Linux ARM.
Updating their version of ReScript to
11.1.4fixed the issue andnpm ciis as fast as for other runners.