Draft
Conversation
Just to see how things look like. One comment is that the local file `Object.res` had to be renames as otherwise it would become unreachable. This is a side-effect of doing `-open RescriptCore` globally, which overrides the local scope. This won't be a problem when the library is integrated in the compiler.
cristianoc
commented
Mar 7, 2023
| "label": "typeof", | ||
| "kind": 12, | ||
| "tags": [], | ||
| "detail": "'a => Core__Type.t", |
Collaborator
Author
There was a problem hiding this comment.
Notice Core__Type.t is leaked.
Member
There was a problem hiding this comment.
Yeah, I think we'll need to special case Core. Good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to see how things look like.
One comment is that the local file
Object.reshad to be renames as otherwise it would become unreachable. This is a side-effect of doing-open RescriptCoreglobally, which overrides the local scope. This won't be a problem when the library is integrated in the compiler.