Make rewatch the default build system / cli#7593
Merged
Conversation
cknitt
force-pushed
the
rewatch-default-cli
branch
from
19599c7 to
d20cf6d
Compare
cknitt
force-pushed
the
rewatch-default-cli
branch
from
d20cf6d to
4adf7a7
Compare
cknitt
force-pushed
the
rewatch-default-cli
branch
2 times, most recently
from
86a3443 to
ebe9d25
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
cknitt
force-pushed
the
rewatch-default-cli
branch
from
ebe9d25 to
6cac813
Compare
cknitt
force-pushed
the
rewatch-default-cli
branch
from
26d2bea to
80e7d1e
Compare
cknitt
changed the title
Member
|
@cknitt worked like a charm for me. Was able to replace all rewatch commands with rescript without any problems. |
zth
approved these changes
Jul 5, 2025
| }, | ||
| "dependencies": { | ||
| "rescript": "12.0.0-alpha.13" | ||
| "rescript": "https://pkg.pr.new/rescript-lang/rescript@6cac813" |
Member
Author
There was a problem hiding this comment.
Yes, otherwise it won't work because rescript-legacy.exe won't be found.
Member
There was a problem hiding this comment.
Got it. But what about going forward? When does it need to be updated? I ask since it points to a hash.
Member
Author
There was a problem hiding this comment.
Ideally we would integrate the rewatch testrepo into the main workspace instead, but I haven't managed to do that.
If we stay with the current "workaround", we would update this dependency to the next alpha/beta release where this PR is already included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on the work done in #7551 to actually make rewatch the default build system and CLI.
The changes also make it clear - see usage of
rescript legacy build- that rewatch is not currently able to build the various test repos other than its own (dependencies not found, panics). This needs to be investigated separately (see #7117).Closes #7588
Next up: #7589