feat: open command for broadcasts and templates to open in browser#104
Merged
felipefreitag merged 7 commits intoresend:mainfrom Mar 20, 2026
Merged
Conversation
…tor open command to use openInBrowser
…DASHBOARD_URLS with RESEND_URLS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/lib/browser.ts">
<violation number="1" location="src/lib/browser.ts:19">
P2: Windows URL opening uses `cmd.exe /c start` with an unescaped URL, allowing CMD metacharacters (e.g., `&`) to break execution or inject commands.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
Author
|
hey @felipefreitag any thoughts here? |
… test mocks - Remove /editor suffix from broadcast URL to match dashboard pattern - Remove misleading "or alias" from template open argument description - Remove alias test case that didn't test real alias resolution - Mock openInBrowserOrLog instead of openInBrowser in all open tests
felipefreitag
approved these changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/lib/browser.ts">
<violation number="1" location="src/lib/browser.ts:19">
P2: Windows `cmd.exe` invocation is vulnerable to argument injection because `url` is manually quoted while `windowsVerbatimArguments` is enabled.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
felipefreitag
force-pushed
the
feat/open-broadcasts-templates
branch
from
5d3a2ef to
3efdeba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added command to open
in the default browser. similar to
resend openfor emails.related #103
Summary by cubic
Adds
resend broadcasts openandresend templates opento open lists or specific items in the dashboard. Refactors open behavior into a shared util with consistent output; updatesresend openandresend auth login.New Features
resend broadcasts open [id]opens the broadcasts list or a specific broadcast.resend templates open [id]opens the templates list or a specific template.openInBrowserOrLogandRESEND_URLS; respect--json/--quiet.Bug Fixes
/editor).cmd.exemetacharacter issues.templates openaccepts only an ID.openInBrowserOrLogto match the new behavior.Written for commit 3efdeba. Summary will update on new commits.