fix: use async profile rename in invalid-profile prompt flow#124
Merged
felipefreitag merged 3 commits intoresend:mainfrom Mar 19, 2026
Merged
Conversation
Ensure the invalid-profile prompt uses the async rename path so secure-storage backed credentials are moved when a legacy profile is renamed.
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
vcapretz
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renameProfileAsync()inpromptRenameIfInvalid()Why
The invalid-profile prompt flow was still using the synchronous rename path, which only updates the credentials file. For users with
secure_storageenabled, that could rename the profile entry without moving the stored API key in the credential backend, leaving the renamed profile unable to resolve its key.Summary by cubic
Switched the invalid-profile rename prompt to use the async rename path. This moves secure-storage credentials with the rename and prevents broken profiles after renaming legacy entries.
renameProfileAsync()withawaitinpromptRenameIfInvalid().Written for commit 75a00cc. Summary will update on new commits.