Feature: RSR staking yield estimator#513
Draft
SharkofMirkwood wants to merge 3 commits intoreserve-protocol:masterfrom
Draft
Feature: RSR staking yield estimator#513SharkofMirkwood wants to merge 3 commits intoreserve-protocol:masterfrom
SharkofMirkwood wants to merge 3 commits intoreserve-protocol:masterfrom
Conversation
Collaborator
|
love it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I have been following Reserve for a while and this is a draft of a contribution I'd like to offer to the Register app. This PR adds a new page with a staking yield estimator, as outlined by 0xJMG on the forum: https://forum.reserve.org/t/rtoken-staking-estimator-worksheet/1009
The logic used is the same as the spreadsheet, but it looks at all the featured RTokens and makes the yield calculations for these tokens, pointing to the staking page for each one.
There are a couple of improvements I'd like to make, either as part of this PR or later on if you prefer to ship incrementally. For example:
However, I think there is value in this page as it is and so I'm opening this PR as a draft while I work on these improvements.
I noticed you have feature branches being deployed from GitHub Actions (though not sure if that's only for team members' contributions!), so my aim is to share the work in progress to the forum for evaluation as well as get some early-ish feedback on the PR itself. For a start I'm not even certain whether this contribution to the app is desired.
Here is a screenshot of the new page: