Skip to content

Fix: event setup to initialize with an empty array #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhucik wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: event setup to initialize with an empty array #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
879f82e
Fix event setup to initialize with an empty array
mhucik Feb 7, 2026
890b473
Use nullable type for eventArgs parameter
mhucik Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Events/DI/EventsExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ protected function bindEventProperties(Definition $def, \ReflectionClass $class)
}

$dispatchAnnotation = self::propertyHasAnnotation($property, 'globalDispatchFirst');
$def->addSetup('$' . $name, [
$def->addSetup('$' . $name . '[]', [
new Statement($this->prefix('@manager') . '::createEvent', [
[$class->getName(), $name],
new PhpLiteral('$service->' . $name),
Expand Down
2 changes: 1 addition & 1 deletion src/Events/EventManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function setExceptionHandler(IExceptionHandler $exceptionHandler)
* @param string $eventName The name of the event to dispatch. The name of the event is the name of the method that is invoked on listeners.
* @param \Doctrine\Common\EventArgs $eventArgs The event arguments to pass to the event handlers/listeners. If not supplied, the single empty EventArgs instance is used
*/
public function dispatchEvent($eventName, DoctrineEventArgs $eventArgs = NULL)
public function dispatchEvent($eventName, ?DoctrineEventArgs $eventArgs = NULL)
{
if ($this->panel) {
$this->panel->eventDispatch($eventName, $eventArgs);
Expand Down