fix(TrapFocus): don't refocus when another component intentionally moves focus#597
Open
egucciar wants to merge 1 commit intoreshaped-ui:canaryfrom
Open
Conversation
…ves focus The MutationObserver was forcibly pulling focus back into the flyout whenever a DOM mutation occurred while focus was outside the root. This broke external components (e.g. Radix Select) that render a portal and legitimately move focus out of the trap. The observer's original intent is to recover from accidental focus loss caused by a focused element being removed from the DOM — in which case the browser resets activeElement to document.body. Adding a guard for this condition preserves that behavior while leaving intentional focus moves (activeElement is a real element) untouched. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MutationObserver was forcibly pulling focus back into the flyout whenever a DOM mutation occurred while focus was outside the root. This broke external components (e.g. Radix Select) that render a portal and legitimately move focus out of the trap.
The observer's original intent is to recover from accidental focus loss caused by a focused element being removed from the DOM — in which case the browser resets activeElement to document.body. Adding a guard for this condition preserves that behavior while leaving intentional focus moves (activeElement is a real element) untouched.
Related Issue
#596