Skip to content

fix: prevent mixing responsive viewport keys with T's keys in Responsive<T> #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blvdmitry merged 1 commit into from
Apr 19, 2026
+6 −1
Merged

fix: prevent mixing responsive viewport keys with T's keys in Responsive<T> #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/reshaped/src/types/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import React from "react";

export type Viewport = "s" | "m" | "l" | "xl";
export type ResponsiveOnly<T> = { [key in Viewport]?: T };

// if ResponsiveOnly<T> is { [key in Viewport]?: T } without the intersection and T is an object such as ButtonProps,
// Responsive<T> would allow mixing keys of T with viewport keys without any type error
export type ResponsiveOnly<T> = { [key in Viewport]?: T } & (T extends object
? { [K in Exclude<keyof T & string, Viewport>]?: never }
: Record<never, never>);
export type Responsive<T> = T | ResponsiveOnly<T>;

/**
Expand Down
Loading