Skip to content

Use CommonFields in MembersRequest #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neur0toxine merged 2 commits into from
Mar 26, 2025
Merged

Use CommonFields in MembersRequest #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a23562
Use CommonFields in MembersRequest
Chupocabra Mar 25, 2025
f65dcac
ignore phpstan setID type error
Chupocabra Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,6 +1355,11 @@ parameters:
count: 1
path: src/Bot/Model/Request/MembersRequest.php

-
message: "#^Method RetailCrm\\\\Mg\\\\Bot\\\\Model\\\\Request\\\\MembersRequest\\:\\:setId\\(\\) has no return typehint specified\\.$#"
count: 1
path: src/Bot/Model/Request/MembersRequest.php

-
message: "#^Method RetailCrm\\\\Mg\\\\Bot\\\\Model\\\\Request\\\\MembersRequest\\:\\:setSince\\(\\) has no return typehint specified\\.$#"
count: 1
Expand Down
51 changes: 1 addition & 50 deletions src/Bot/Model/Request/MembersRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
*/
class MembersRequest implements ModelInterface
{
use CommonFields;
use PageLimit;

/**
Expand Down Expand Up @@ -51,24 +52,6 @@ class MembersRequest implements ModelInterface
*/
private $state;

/**
* @var string $since
*
* @Type("string")
* @Accessor(getter="getSince",setter="setSince")
* @SkipWhenEmpty
*/
private $since;

/**
* @var string $until
*
* @Type("string")
* @Accessor(getter="getUntil",setter="setUntil")
* @SkipWhenEmpty
*/
private $until;

/**
* @return int
*/
Expand Down Expand Up @@ -116,36 +99,4 @@ public function setState(string $state)
{
$this->state = $state;
}

/**
* @return string
*/
public function getSince()
{
return $this->since;
}

/**
* @param string $since
*/
public function setSince(string $since)
{
$this->since = $since;
}

/**
* @return string
*/
public function getUntil()
{
return $this->until;
}

/**
* @param string $until
*/
public function setUntil(string $until)
{
$this->until = $until;
}
}