Add DXGI MakeWindowAssociation constants#960
Open
Herschel wants to merge 1 commit intoretep998:0.3from
Open
Conversation
3 tasks
bors Bot
added a commit
to gfx-rs/gfx
that referenced
this pull request
Nov 17, 2020
3479: [dx] Disable automatic Alt+Enter handling in DXGI r=kvark a=Herschel Fixes #3477. Uses [IDXGIFactory::MakeWindowAssociation](https://docs.microsoft.com/en-us/windows/win32/api/dxgi/nf-dxgi-idxgifactory-makewindowassociation) to disable Alt+Enter behavior on dx11/dx12 backends. * winapi-rs does not have the `DXGI_MWA` constants (opened PR retep998/winapi-rs#960). Not sure where to cram these -- for now, I put them right beside the function call. * Using both `DXGI_MWA_NO_WINDOW_CHANGES | DXGI_MWA_NO_ALT_ENTER`. Either of these seems to disable the Alt+Enter behavior; according to the docs, `DXGI_MWA_NO_WINDOW_CHANGES` seems more general, but I guess this is desired (DXGI shouldn't fiddle with anything automatically for consistent behavior among backends?). PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: - dx11, dx12, vulkan Co-authored-by: Mike Welsh <mwelsh@gmail.com>
MaulingMonkey
approved these changes
Nov 27, 2020
Contributor
MaulingMonkey
left a comment
MaulingMonkey
left a comment
There was a problem hiding this comment.
LGTM! 👍
- The bindings match the headers (
C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\shared\dxgi.h) - The bindings respect https://github.com/retep998/winapi-rs/blob/0.3/CONTRIBUTING.md#constants
- The bindings respect https://github.com/retep998/winapi-rs/blob/0.3/CONTRIBUTING.md#organization-of-code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add constants used by
IDXGIFactory::MakeWindowAssociation: