refactor: convert operation-style bool returns to Result - #15
Merged
Conversation
retsimx
commented
Mar 23, 2026
retsimx
commented
Owner
- Replace functions that signal operation success/failure via bool with Result<(), ()>, distinguishing success (Ok) from failure (Err) explicitly
- Update all call sites to use .is_ok()/.is_err() or match on the Result
- Update all mocks in tests to return Ok(())/Err(()) instead of true/false
- Crypto decryption operations now propagate errors through the type system rather than silently returning false on MIC mismatch or I/O failure
- OTA area validation now surfaces hardware I/O errors separately from logical invalidity via Result<bool, ()>
- Replace functions that signal operation success/failure via bool with Result<(), ()>, distinguishing success (Ok) from failure (Err) explicitly - Update all call sites to use .is_ok()/.is_err() or match on the Result - Update all mocks in tests to return Ok(())/Err(()) instead of true/false - Crypto decryption operations now propagate errors through the type system rather than silently returning false on MIC mismatch or I/O failure - OTA area validation now surfaces hardware I/O errors separately from logical invalidity via Result<bool, ()>
📊 Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.