Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new policy conflicts with the immediate speculative MSRV increase, and the upgrade guide misstates Cargo behavior and dependency direction.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Separates application-tier MSRVs from the embeddable library crates and decouples xtask from brush-shell.
Changes:
- Sets application-tier crates to Rust 1.95.0.
- Dynamically excludes higher-MSRV crates from MSRV CI builds.
- Moves artifact generation into a
brush-shellexample.
File summaries
| File | Description |
|---|---|
xtask/src/generate.rs |
Delegates generation to the new example. |
xtask/src/ci.rs |
Adapts build-check construction. |
xtask/src/check.rs |
Adds MSRV-aware workspace exclusions. |
xtask/Cargo.toml |
Removes shell and generation dependencies. |
fuzz/Cargo.toml |
Sets application-tier MSRV. |
docs/reference/msrv-policy.md |
Documents the tiered policy. |
docs/how-to/upgrade-msrv.md |
Documents upgrade procedures. |
Cargo.lock |
Relocates generation dependencies. |
brush/Cargo.toml |
Sets application-tier MSRV. |
brush-shell/examples/gen.rs |
Implements artifact generation. |
brush-shell/Cargo.toml |
Registers generator and dependencies. |
brush-interactive/Cargo.toml |
Sets application-tier MSRV. |
.github/workflows/ci.yaml |
Configures MSRV build arguments. |
.github/copilot-instructions.md |
Updates contributor guidance. |
Review details
- Files reviewed: 13/14 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Results 5 files 49 suites 21m 36s ⏱️ Results for commit aa848b0. ♻️ This comment has been updated with latest results. |
Performance Benchmark ReportCode Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
…MSRV Leaves the workspace-wide `rust-version` at 1.88.0, for the benefit of our most commonly emebedded library crates (brush-core, brush-parser, brush-builtins, et al.). brush, brush-shell, brush-interactive, and brush-fuzz now move to 1.95.0 on their own. This allows them to raise their MSRVs independently in order to benefit from newer front-end dependencies like reedline. To make this all work out without requiring `xtask` to also move forward, we also decouple it from `brush-shell. (It previously had a dependency on the latter for help content generation. We now indirect through a `gen` example in brush-shell.) Assisted-By: Claude Opus 5
Leaves the workspace-wide
rust-versionat 1.88.0, for the benefit of our most commonly emebedded library crates (brush-core, brush-parser, brush-builtins, et al.). brush, brush-shell, brush-interactive, and brush-fuzz now move to 1.95.0 on their own. This allows them to raise their MSRVs independently in order to benefit from newer front-end dependencies like reedline.To make this all work out without requiring
xtaskto also move forward, we also decouple it frombrush-shell. (It previously had a dependency on the latter for help content generation. We now indirect through agen` example in brush-shell.)Assisted-By: Claude Opus 5