Skip to content

chore: update reedline to 0.51; update lock file - #1370

Merged
reubeno merged 1 commit into
mainfrom
update-rl-and-deps
Sep 12, 2026
Merged

reubeno merged 1 commit into
mainfrom
update-rl-and-deps

Conversation

@reubeno

@reubeno reubeno commented Sep 11, 2026

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

Copy link
Copy Markdown

Test Results

    5 files     49 suites   24m 10s ⏱️
2 949 tests 2 949 ✅ 0 💤 0 ❌
9 145 runs  9 145 ✅ 0 💤 0 ❌

Results for commit 734d514.

@github-actions

Copy link
Copy Markdown

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 18.46 μs 18.69 μs 0.23 μs 🟠 +1.22%
eval_arithmetic 0.14 μs 0.15 μs 0.00 μs ⚪ Unchanged
expand_one_string 1.91 μs 1.98 μs 0.07 μs ⚪ Unchanged
for_loop 29.50 μs 30.48 μs 0.98 μs 🟠 +3.32%
full_peg_complex 56.56 μs 55.94 μs -0.62 μs 🟢 -1.10%
full_peg_for_loop 6.42 μs 6.35 μs -0.07 μs ⚪ Unchanged
full_peg_nested_expansions 15.95 μs 15.96 μs 0.01 μs ⚪ Unchanged
full_peg_pipeline 4.30 μs 4.31 μs 0.01 μs ⚪ Unchanged
full_peg_simple 1.77 μs 1.79 μs 0.02 μs ⚪ Unchanged
function_call 4.23 μs 4.36 μs 0.13 μs ⚪ Unchanged
instantiate_shell 54.79 μs 55.45 μs 0.67 μs 🟠 +1.21%
instantiate_shell_with_init_scripts 26315.00 μs 26724.09 μs 409.08 μs ⚪ Unchanged
parse_peg_bash_completion 2276.76 μs 2266.14 μs -10.61 μs ⚪ Unchanged
parse_peg_complex 18.57 μs 18.49 μs -0.08 μs ⚪ Unchanged
parse_peg_for_loop 1.94 μs 1.95 μs 0.01 μs ⚪ Unchanged
parse_peg_pipeline 2.12 μs 2.10 μs -0.01 μs ⚪ Unchanged
parse_peg_simple 1.09 μs 1.09 μs -0.00 μs ⚪ Unchanged
run_echo_builtin_command 13.89 μs 13.94 μs 0.06 μs ⚪ Unchanged
tokenize_sample_script 3.60 μs 3.53 μs -0.07 μs 🟢 -1.92%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 77.2% 🟢 77.19% 🔴 -0.01%

Minimum allowed coverage is 70%, this run produced 77.19%
Maximum allowed coverage difference is -5%, this run produced -0.01%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1588 75.30
❗️ Error 16 0.76
❌ Fail 151 7.16
⏩ Skip 339 16.07
❎ Expected Fail 13 0.62
✔️ Unexpected Pass 2 0.09
📊 Total 2109 100.00

@reubeno
reubeno requested a balanced review from Copilot September 12, 2026 01:09
@reubeno
reubeno marked this pull request as ready for review September 12, 2026 01:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Updates Reedline to 0.51, adapts the interactive backend APIs, and refreshes related dependencies.

Changes:

  • Updates Reedline and test-with.
  • Migrates prompt colors and completion APIs.
  • Refreshes Cargo.lock.
File summaries
File Description
Cargo.lock Updates dependency versions.
brush-shell/Cargo.toml Updates test-with.
brush-interactive/src/reedline/prompt.rs Adapts prompt color variants.
brush-interactive/src/reedline/completer.rs Adapts the completion result API.
brush-interactive/Cargo.toml Upgrades Reedline.
Review details
  • Files reviewed: 4/5 changed files
  • Comments generated: 0
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@reubeno
reubeno merged commit 25bffd5 into main Sep 12, 2026
53 checks passed
@reubeno
reubeno deleted the update-rl-and-deps branch September 12, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants