Skip to content

feat: Add a solarized-dark preset#108

Merged
DeclanChidlow merged 4 commits into
revoltchat:masterfrom
CrystalENVT:master
May 26, 2025
Merged

feat: Add a solarized-dark preset#108
DeclanChidlow merged 4 commits into
revoltchat:masterfrom
CrystalENVT:master

Conversation

@CrystalENVT

Copy link
Copy Markdown
Contributor

chore: Add emacs temp files to gitignore

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

CrystalENVT and others added 4 commits May 25, 2025 20:33
chore: Add emacs temp files to gitignore
Signed-off-by: CrystalSpore <sporeluc@gmail.com>
@DeclanChidlow DeclanChidlow merged commit a1d655d into revoltchat:master May 26, 2025
1 check passed
@CrystalENVT

Copy link
Copy Markdown
Contributor Author

@DeclanChidlow Quick question, I copied the Dracula Preset, & they have a link there that references the color set, so I linked tho the Solarized Dark page. -> https://github.com/revoltchat/themes/blob/master/data/dracula/Preset.toml#L4

Should links not exist at all within the project, or should the link get re-added for a reference standpoint?

I'm okay with whatever answer, just wanting to ask for consistency :)

@DeclanChidlow

Copy link
Copy Markdown
Member

It is my personal opinion that links shouldn't be included as it constitutes some endorsement and increases maintenance burden against link rot.

It is my intention at some point to go through and clean up the metadata of all themes.

@CrystalENVT

Copy link
Copy Markdown
Contributor Author

Sure thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants