fix(cvar): use locale-independent serialization for double cvars#320
Open
birabittoh wants to merge 1 commit intorexglue:developmentfrom
Open
fix(cvar): use locale-independent serialization for double cvars#320birabittoh wants to merge 1 commit intorexglue:developmentfrom
birabittoh wants to merge 1 commit intorexglue:developmentfrom
Conversation
std::to_string(double) respects the C locale but can produce comma decimal separators on systems where LC_ALL/LC_NUMERIC is set to a locale like it_IT or de_DE. TOML requires a period, so the written config file would fail to parse on the next launch. Replace with a std::to_chars-based helper (DoubleToString) which is locale-independent per the C++ standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::to_string(double) respects the C locale but can produce comma decimal separators on systems where LC_ALL/LC_NUMERIC is set to a locale like it_IT or de_DE. TOML requires a period, so the written config file would fail to parse on the next launch.
Replace with a std::to_chars-based helper (DoubleToString) which is locale-independent per the C++ standard.
Addresses #318.