Skip to content

Allow PHP 8.4 and 8.5 - #6

Merged
dgburns92 merged 1 commit into
mainfrom
feat/php-8-5
Sep 17, 2026
Merged

dgburns92 merged 1 commit into
mainfrom
feat/php-8-5

Conversation

@dgburns92

Copy link
Copy Markdown
Contributor

Part of the calendar-api PHP 8.3 → 8.5 hop (BT-278), wave 3 of the release train: rexlabs/hyper-http is one of the rexlabs packages whose php constraint stops Composer resolving on 8.5. Shaped like the previous PHP-support bumps in this repo.

  • composer.json: php upper bound to <8.6.
  • CI matrix gains 8.4 and 8.5 (php:X-cli-alpine, same job as before; checkout action on v4).
  • CHANGELOG entry for 4.2.0.
  • Three implicitly nullable parameters (\Throwable $previous = null in ApiException, GuzzleClient $guzzle = null and LoggerInterface $logger = null in Hyper::make() and Hyper::instance()) are declared ?\Throwable / ?GuzzleClient / ?LoggerInterface. PHP 8.4 deprecates the implicit form.

Its three rexlabs dependencies are released, so the 8.4/8.5 cells can resolve: rexlabs/utility-belt 4.2.0, rexlabs/array-object 3.2.1, rexlabs/cuzzle 3.2.0.

Release as 4.2.0 after merge.

🤖 Generated with Claude Code

php constraint widened to <8.6 and the CI matrix runs on the new versions.
Suite passes on PHP 8.5 locally with the same job the workflow runs (the
rexlabs dependencies' own php caps ignored until their releases land).
Implicitly nullable parameters, deprecated since PHP 8.4, are declared
nullable where the suite raised them.
CHANGELOG entry for 4.2.0.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no concrete behavioral, compatibility, security, or repository-rule violations identified.

Summary

This PR extends the package’s declared and tested PHP support through PHP 8.5 while eliminating PHP 8.4 implicit-nullability deprecations.

  • Expands the Composer PHP constraint from <8.4 to <8.6.
  • Adds PHP 8.4 and 8.5 to both CI dependency-resolution modes.
  • Makes nullable exception, Guzzle client, and logger parameters explicit.
  • Documents the changes for release 4.2.0.

Reviews (1) · Last reviewed commit: "Allow PHP 8.4 and 8.5"

@dgburns92
dgburns92 merged commit 7882d4b into main Sep 17, 2026
17 checks passed
@dgburns92
dgburns92 deleted the feat/php-8-5 branch September 17, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants