Repository navigation
fix(acp): release completed Codex sessions on Linux - #22
Merged
Merged
Conversation
Signed-off-by: Andrey Bruhanov <mail@alamra.net>
reynholm
marked this pull request as ready for review
October 16, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed Codex turns on Linux retained worker slots because the late
codex-code-mode-hostwas counted as background work. Five finished scopes could exhaust a five-worker pool. Linux now confirms the host through a boundedps exelookup, while real work under that host still protects its original session and result collection. macOS keeps its existingcommbehavior.Regression coverage exercises six scopes through five real ACP workers, child completion and original-session collection, work arguments, symlink rejection, and a running executable removed from disk. Linux RED: 5 failed / 1 passed; fixed: 6 passed. Full package: native Linux 1107 passed / 0 failed / 7 ignored, macOS 1104 / 0 / 7; clippy both platforms, fmt, registry and Python 77 pass. Gronen reviewed exact commit
7cbeb88027bde0db591d208bb1ada26b91f9fb14: PASS, no confirmed defects (Buzz event4d2943b767c388fa68ec7d21b84ba31a36acfcbcdf174bca9bc88764c6b14f0c). No relay or wire-protocol changes.Linux runtime evidence uses native ARM64 Ubuntu 22.04; Rosetta x86 emulation substitutes its own executable path and is unsuitable for this identity test. Native x86_64 CI is separate. Installed Desktop/Codex human acceptance remains unclaimed.
The first full Linux run had one existing Claude launcher timeout failure: a non-reaping container PID 1 retained a killed zombie. The same binary reproduced it without a reaper and passed with
--init; the complete unchanged package then passed with init. No tests or timeouts were weakened.Review limits: Gronen inspected sources and source-bound author logs, not a fresh full test run. A fork-before-exec snapshot window remains; regressions acknowledge work after exec. Failed executable confirmation conservatively keeps the slot occupied. Owner explicitly authorized review, push, merge, and Linux Desktop build in Buzz event
965a7f24ffcf3a7a8a18785ace514c473bb27db5327208039de7038a5430e990; human installed-app acceptance is not claimed.Full local
just ci desktop-typecheckpassed at exact7cbeb880(exit 0); all 5589 snapshotted regular inputs still match and the tree is clean. Includes repository static checks, Rust unit suites, Desktop JS 7068/0, native Desktop tests, frontend/web builds and mobile suites. Hosted CI remains a separate gate.